gtk4.git
20 years agoDon't crash on duplicate destroy. (#318953, Gustavo Carneiro)
Matthias Clasen [Wed, 26 Oct 2005 19:47:48 +0000 (19:47 +0000)]
Don't crash on duplicate destroy. (#318953, Gustavo Carneiro)

2005-10-26  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
on duplicate destroy.  (#318953, Gustavo Carneiro)

20 years agoDoc updates
Matthias Clasen [Wed, 26 Oct 2005 19:10:08 +0000 (19:10 +0000)]
Doc updates

20 years agouse $(GLIB_MKENUMS) instead of glib-mkenums. (#318582, Damien Carbery)
Matthias Clasen [Wed, 26 Oct 2005 18:01:05 +0000 (18:01 +0000)]
use $(GLIB_MKENUMS) instead of glib-mkenums. (#318582, Damien Carbery)

2005-10-26  Matthias Clasen  <mclasen@redhat.com>

        * */Makefile.am: use $(GLIB_MKENUMS) instead of
        glib-mkenums.  (#318582, Damien Carbery)

20 years agoClarify docs. (#317682, Christian - Manny Calavera - Neumair)
Matthias Clasen [Wed, 26 Oct 2005 14:43:10 +0000 (14:43 +0000)]
Clarify docs. (#317682, Christian - Manny Calavera - Neumair)

2005-10-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
        docs.  (#317682, Christian - Manny Calavera - Neumair)

20 years agoFixed typos reported by kano@na.rim.or.jp.
Takeshi AIHANA [Wed, 26 Oct 2005 14:29:03 +0000 (14:29 +0000)]
Fixed typos reported by kano@na.rim.or.jp.

2005-10-26  Takeshi AIHANA <aihana@gnome.gr.jp>

* ja.po: Fixed typos reported by kano@na.rim.or.jp.

20 years agoFix #317844
Matthias Clasen [Wed, 26 Oct 2005 13:42:53 +0000 (13:42 +0000)]
Fix #317844

20 years agoFix some issues with background drawing in RTL. (#318781, Eric Cazeaux)
Matthias Clasen [Wed, 26 Oct 2005 04:23:46 +0000 (04:23 +0000)]
Fix some issues with background drawing in RTL. (#318781, Eric Cazeaux)

2005-10-25  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
        Fix some issues with background drawing in RTL.  (#318781,
        Eric Cazeaux)

20 years agoAdd property editors
Matthias Clasen [Wed, 26 Oct 2005 03:55:35 +0000 (03:55 +0000)]
Add property editors

20 years agoActivate status icons on single click
Matthias Clasen [Wed, 26 Oct 2005 03:18:09 +0000 (03:18 +0000)]
Activate status icons on single click

20 years agoFixes #311955, reported by Markku Vire; and a lot more.
Kristian Rietveld [Tue, 25 Oct 2005 21:00:40 +0000 (21:00 +0000)]
Fixes #311955, reported by Markku Vire; and a lot more.

2005-10-25  Kristian Rietveld  <kris@gtk.org>

Fixes #311955, reported by Markku Vire; and a lot more.

* gtk/gtktreemodelfilter.c: Made this thing work correctly.
Levels can now have invisible nodes cached, functions have been
rewritten/refactored to take this into account; also the logic in
some functions has been corrected.

Each referenced node now references all visible children or a single
invisible child, in order to be able to monitor all changes in the
child model required for correct operation.

When a virtual root is set, all nodes on the virtual root level are
referenced.

At last, a bunch of random bug fixes and comment updates.

20 years agoAdd some more docs. (#319722, Paolo Borelli)
Matthias Clasen [Tue, 25 Oct 2005 18:28:35 +0000 (18:28 +0000)]
Add some more docs. (#319722, Paolo Borelli)

2005-10-25  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
more docs.  (#319722, Paolo Borelli)

20 years agoMake the initialization of screen_x11->xft_rgba more explicit. (#319627,
Matthias Clasen [Tue, 25 Oct 2005 18:11:57 +0000 (18:11 +0000)]
Make the initialization of screen_x11->xft_rgba more explicit. (#319627,

2005-10-25  Matthias Clasen  <mclasen@redhat.com>

* gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
initialization of screen_x11->xft_rgba more explicit.  (#319627,
Bogdan Nicula)

20 years agoDon't use deprecated functions in examples. (#319524, Vincent Untz)
Matthias Clasen [Tue, 25 Oct 2005 18:00:49 +0000 (18:00 +0000)]
Don't use deprecated functions in examples. (#319524, Vincent Untz)

2005-10-25  Matthias Clasen  <mclasen@redhat.com>

* gtk/tmpl/gtkfilechooser.sgml: Don't use deprecated functions
in examples.  (#319524, Vincent Untz)

* gtk/gtk-update-icon-cache.xml: Fix a typo.  (#319524, Vincent Untz)

20 years agoFix whitespace in a blurb. (#319499, Francisco Javier F. Serrador)
Matthias Clasen [Tue, 25 Oct 2005 17:57:35 +0000 (17:57 +0000)]
Fix whitespace in a blurb. (#319499, Francisco Javier F. Serrador)

2005-10-25  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
in a blurb.  (#319499, Francisco Javier F. Serrador)

20 years agoUpdated Simplified Chinese translations.
Funda Wang [Tue, 25 Oct 2005 13:24:28 +0000 (13:24 +0000)]
Updated Simplified Chinese translations.

20 years agoAdd settings to hide the input method and Unicode control character
Matthias Clasen [Mon, 24 Oct 2005 20:01:57 +0000 (20:01 +0000)]
Add settings to hide the input method and Unicode control character

2005-10-24  Matthias Clasen  <mclasen@redhat.com>

        Add settings to hide the input method and Unicode control character
        submenus in the context menus of GtkEntry and GtkTextView.

        * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.

        * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.

        * gtk/gtktextview.c (popup_targets_received):
        * gtk/gtkentry.c (popup_targets_received): Use the settings here.

20 years agoemitting row-has-child-toggled when the level is not in the cache does not
Kristian Rietveld [Mon, 24 Oct 2005 19:01:36 +0000 (19:01 +0000)]
emitting row-has-child-toggled when the level is not in the cache does not

2005-10-24  Kristian Rietveld  <kris@gtk.org>

* gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
row-has-child-toggled when the level is not in the cache does not
make sense.  (This bug probably crept in during the early stages
of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
implementation yet),
(gtk_tree_model_sort_real_unref_node): only get the child iter
when we will actually also use it.

20 years agoUpdated Spanish translation.
Francisco Javier F. Serrador [Sat, 22 Oct 2005 22:19:15 +0000 (22:19 +0000)]
Updated Spanish translation.

2005-10-23  Francisco Javier F. Serrador  <serrador@cvs.gnome.org>

* es.po: Updated Spanish translation.

20 years agoUpdated Spanish translation.
Francisco Javier F. Serrador [Sat, 22 Oct 2005 21:57:03 +0000 (21:57 +0000)]
Updated Spanish translation.

2005-10-22  Francisco Javier F. Serrador  <serrador@cvs.gnome.org>

* es.po: Updated Spanish translation.

20 years agocheck for the widget being realized, in addition to being visible, to
Michael Natterer [Sat, 22 Oct 2005 21:08:23 +0000 (21:08 +0000)]
check for the widget being realized, in addition to being visible, to

2005-10-22  Michael Natterer  <mitch@imendio.com>

* gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
widget being realized, in addition to being visible, to avoid
running into precondition check in gtk_tree_view_get_cell_area().
(approved by Kris).

20 years agoExperimentally, scrollbar steppers can shrink to 8 pixels on Win32.
Dom Lachowicz [Sat, 22 Oct 2005 15:53:00 +0000 (15:53 +0000)]
Experimentally, scrollbar steppers can shrink to 8 pixels on Win32.

* modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
Experimentally, scrollbar steppers can shrink to 8 pixels on
Win32. Reflect that in the theme.
* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
there is a 1-pixel border between a scrollbar and its child
in ScrolledWindows on Win32. Reflect that in the theme.

20 years agoUpdated Bulgarian translation by Alexander Shopov <ash@contact.bg>
Alexander Shopov [Fri, 21 Oct 2005 08:20:45 +0000 (08:20 +0000)]
Updated Bulgarian translation by Alexander Shopov <ash@contact.bg>

2005-10-21  Alexander Shopov  <ash@contact.bg>

* bg.po: Updated Bulgarian translation by
Alexander Shopov <ash@contact.bg>

20 years agoUse GDK_WINDOW_CHILD for the selection window. (#318806, Alex Larsson)
Matthias Clasen [Thu, 20 Oct 2005 20:40:54 +0000 (20:40 +0000)]
Use GDK_WINDOW_CHILD for the selection window. (#318806, Alex Larsson)

2005-10-20  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
for the selection window.  (#318806, Alex Larsson)

20 years agoAdded Entry for Bengali (bn) Translation Updation:20/10
Runa Bhattacharjee [Thu, 20 Oct 2005 05:39:25 +0000 (05:39 +0000)]
Added Entry for Bengali (bn) Translation Updation:20/10

20 years agoUpdated Bengali(bn) Translation:20/10
Runa Bhattacharjee [Thu, 20 Oct 2005 05:39:11 +0000 (05:39 +0000)]
Updated Bengali(bn) Translation:20/10

20 years ago*** empty log message ***
Ignacio Casal Quinteiro [Wed, 19 Oct 2005 23:09:08 +0000 (23:09 +0000)]
*** empty log message ***

20 years agoFixed some typos.
Inaki Larranaga [Wed, 19 Oct 2005 18:30:45 +0000 (18:30 +0000)]
Fixed some typos.

2005-10-19  Inaki Larranaga  <dooteo@euskalgnu.org>

* eu.po: Fixed some typos.

20 years agoFixes bug #317999:
Federico Mena Quintero [Wed, 19 Oct 2005 16:25:42 +0000 (16:25 +0000)]
Fixes bug #317999:

2005-10-18  Federico Mena Quintero  <federico@ximian.com>

Fixes bug #317999:

* tests/autotestfilechooser.c
(test_button_folder_states_for_action): Test that we have either
$cwd or the explicitly-set folder.
(test_reload_sequence): Likewise.

* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_get_current_folder): If our reload_state
is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.

20 years agoMake magic comparisons work correctly in the cache.
Matthias Clasen [Tue, 18 Oct 2005 20:32:35 +0000 (20:32 +0000)]
Make magic comparisons work correctly in the cache.

2005-10-18  Matthias Clasen  <mclasen@redhat.com>

        * xdgmimecache.c: Make magic comparisons work correctly
        in the cache.

20 years agoRemove a debugging printf.
Matthias Clasen [Tue, 18 Oct 2005 02:54:55 +0000 (02:54 +0000)]
Remove a debugging printf.

2005-10-17  Matthias Clasen  <mclasen@redhat.com>

* xdgmime.c (xdg_mime_get_mime_type_for_file): Remove
a debugging printf.

20 years agoFixed translations with context (thanks to Sergej Chodarev).
Marcel Telka [Mon, 17 Oct 2005 23:12:43 +0000 (23:12 +0000)]
Fixed translations with context (thanks to Sergej Chodarev).

2005-10-17  Marcel Telka  <marcel@telka.sk>

* sk.po: Fixed translations with context (thanks to Sergej Chodarev).

20 years agoUpdated Danish translation.
Martin Willemoes Hansen [Mon, 17 Oct 2005 14:19:17 +0000 (14:19 +0000)]
Updated Danish translation.

        * da.po: Updated Danish translation.

20 years agoTranslation updated by Ivar Smolin.
Priit Laes [Mon, 17 Oct 2005 12:41:47 +0000 (12:41 +0000)]
Translation updated by Ivar Smolin.

2005-10-17  Priit Laes  <plaes@cvs.gnome.org>

* et.po: Translation updated by Ivar Smolin.

20 years agoUpdated Danish translation.
Martin Willemoes Hansen [Mon, 17 Oct 2005 10:27:34 +0000 (10:27 +0000)]
Updated Danish translation.

        * da.po: Updated Danish translation.

20 years agoUpdated Traditional Chinese translation. Updated Traditional Chinese
Chao-Hsiung Liao [Mon, 17 Oct 2005 06:36:20 +0000 (06:36 +0000)]
Updated Traditional Chinese translation. Updated Traditional Chinese

2005-10-17 Chao-Hsiung Liao  <j_h_liau@yahoo.com.tw>

* ./po/zh_TW.po: Updated Traditional Chinese translation.
* ./po-properties/zh_TW.po: Updated Traditional Chinese translation.

20 years agoUpdated Slovak translation.
Marcel Telka [Mon, 17 Oct 2005 04:47:43 +0000 (04:47 +0000)]
Updated Slovak translation.

2005-10-17  Marcel Telka  <marcel@telka.sk>

* sk.po: Updated Slovak translation.

20 years agoTranslation updated.
Vincent van Adrighem [Sat, 15 Oct 2005 12:55:02 +0000 (12:55 +0000)]
Translation updated.

2005-10-15  Vincent van Adrighem  <adrighem@gnome.org>

* nl.po: Translation updated.

20 years agoAdded more tests.
Behdad Esfahbod [Sat, 15 Oct 2005 05:22:49 +0000 (05:22 +0000)]
Added more tests.

20 years agoAdd a bunch of missing files. Updated Canadian English translation.
Adam Weinberger [Fri, 14 Oct 2005 16:49:03 +0000 (16:49 +0000)]
Add a bunch of missing files. Updated Canadian English translation.

2005-10-14  Adam Weinberger  <adamw@gnome.org>

* POTFILES.in: Add a bunch of missing files.
* en_CA.po: Updated Canadian English translation.

20 years agoRemove the clipboard viewer code. It didn't really do anything useful, and
Tor Lillqvist [Fri, 14 Oct 2005 00:08:14 +0000 (00:08 +0000)]
Remove the clipboard viewer code. It didn't really do anything useful, and

2005-10-14  Tor Lillqvist  <tml@novell.com>

* gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
It didn't really do anything useful, and was just confusing and
incomplete. Comments claimed we don't do delayed rendering, but in
fact we do, for images. (The delayed rendering code has other
problems, though, see #168173.) The clipboard viewer code was
probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
the message when necessary). It was just test code, it said so in
a comment. Add something similar back later if necessary.

(_win32_on_clipboard_change,
_gdk_win32_register_clipboard_notification): Remove.

(gdk_display_supports_selection_notification,
gdk_display_request_selection_notification): Always just return
FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.

20 years agoTranslation updated by Ivar Smolin.
Priit Laes [Thu, 13 Oct 2005 20:09:00 +0000 (20:09 +0000)]
Translation updated by Ivar Smolin.

2005-10-13  Priit Laes  <plaes@cvs.gnome.org>

* et.po: Translation updated by Ivar Smolin.

20 years agoDon't treat Alt-Enter specially. It does not have any special meaning and
Tor Lillqvist [Thu, 13 Oct 2005 07:21:00 +0000 (07:21 +0000)]
Don't treat Alt-Enter specially. It does not have any special meaning and

2005-10-13  Tor Lillqvist  <tml@novell.com>

* gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
Alt-Enter specially. It does not have any special meaning and
should be passed on to the application. (#318378, Tim Evans)

20 years agoSet visual depth to 24 for 32 bits-per-pixel devices on Win32. This allows
Tor Lillqvist [Thu, 13 Oct 2005 07:08:49 +0000 (07:08 +0000)]
Set visual depth to 24 for 32 bits-per-pixel devices on Win32. This allows

2005-10-13  Tor Lillqvist  <tml@novell.com>

Set visual depth to 24 for 32 bits-per-pixel devices on
Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
optimized composite_0888() function rather than the slower image
dithering functions to draw pixbufs (#313993, John Ehresman)

* gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
_gdk_windowing_get_bits_for_depth() to initialize
GdkImage::bits_per_pixel.
(_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.

* gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
_gdk_windowing_get_bits_for_depth() to initialize
BITMAPINFOHEADER::biBitCount.

* gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
32.

20 years agoOnly call gdk_pixbuf_loader_eat_header_write() when count > 0. (#318589,
Matthias Clasen [Wed, 12 Oct 2005 13:49:26 +0000 (13:49 +0000)]
Only call gdk_pixbuf_loader_eat_header_write() when count > 0. (#318589,

2005-10-12  Matthias Clasen  <mclasen@redhat.com>

* gdk-pixbuf-loader.c (gdk_pixbuf_loader_write): Only call
gdk_pixbuf_loader_eat_header_write() when count > 0.  (#318589,
Bogdan Nicula)

20 years agouse PACKAGE_VERSION,bump year (#318654)
Stefan Kost [Wed, 12 Oct 2005 13:23:10 +0000 (13:23 +0000)]
use PACKAGE_VERSION,bump year (#318654)

* demos/gtk-demo/appwindow.c: (about_cb):
use PACKAGE_VERSION,bump year (#318654)

20 years agoTry to match an off toggle here with the matching on toggle if it
Matthias Clasen [Tue, 11 Oct 2005 14:39:17 +0000 (14:39 +0000)]
Try to match an off toggle here with the matching on toggle if it

2005-10-11  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
toggle here with the matching on toggle if it immediately follows.
This is a common case, and handling it here prevents quadratic blowup
in cleanup_line() below.  (#317125)

* gtk/gtktextsegment.h:
* gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
the character counts into this function instead of computing them
again.

20 years agoAdd ALREADY_EXISTS error code. Return an error code when the shortcut
Tommi Komulainen [Mon, 10 Oct 2005 14:29:03 +0000 (14:29 +0000)]
Add ALREADY_EXISTS error code. Return an error code when the shortcut

2005-10-10  Tommi Komulainen  <tommi.komulainen@iki.fi>

* gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
code.
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_add_shortcut_folder): Return an error code
when the shortcut already exists in the sidebar.  (#147521)

20 years agoDemonstrate custom widgets in a GtkComboBox.
Matthias Clasen [Sun, 9 Oct 2005 16:27:12 +0000 (16:27 +0000)]
Demonstrate custom widgets in a GtkComboBox.

20 years agofix includes
Matthias Clasen [Fri, 7 Oct 2005 20:03:36 +0000 (20:03 +0000)]
fix includes

20 years agoFixes bug #317999:
Federico Mena Quintero [Fri, 7 Oct 2005 19:54:32 +0000 (19:54 +0000)]
Fixes bug #317999:

2005-10-07  Federico Mena Quintero  <federico@ximian.com>

Fixes bug #317999:

* tests/autotestfilechooser.c (test_reload_sequence): Ensure that
the the result of gtk_file_chooser_get_folder() is NULL or
non-NULL at the right times.  Log the tests.
(test_button_folder_states): New test for the initial states of
the current folder in GtkFileChooserButton.
(main): Test that the number of warnings/errors/critical errors is
zero.

* gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
Clarify the documentation on when this can return NULL.
(gtk_file_chooser_get_current_folder_uri): Likewise.

* gtk/gtkfilechooserbutton.c (struct
_GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
we use it to keep track of whether a folder has been set.
(gtk_file_chooser_button_map):  Implement.  If no folder has been
loaded before, we at least try to load $cwd here.
(gtk_file_chooser_button_constructor): If the construct-time
dialog already has a folder set, turn on our folder_has_been_set
flag.
(dialog_current_folder_changed_cb): Turn on our
folder_has_been_set flag.

20 years agoremove some explicit #defines of PROFILE_FILE_CHOOSER because they break
Michael Natterer [Fri, 7 Oct 2005 18:51:30 +0000 (18:51 +0000)]
remove some explicit #defines of PROFILE_FILE_CHOOSER because they break

2005-10-07  Michael Natterer  <mitch@gimp.org>

* gtk/gtkfilechooserdefault.c: remove some explicit #defines of
PROFILE_FILE_CHOOSER because they break compilation after the
removal of <unistd.h>.

20 years agoRemove a redundant (and unconditional) include of unistd.h (#318211,
Matthias Clasen [Fri, 7 Oct 2005 16:20:37 +0000 (16:20 +0000)]
Remove a redundant (and unconditional) include of unistd.h (#318211,

2005-10-07   Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c: Remove a redundant (and
        unconditional) include of unistd.h  (#318211, Kazuki Iwamoto)

20 years agoUse g_return_val_if_fail(), not g_return_if_fail(). (#318412, Kazuki
Matthias Clasen [Fri, 7 Oct 2005 16:01:19 +0000 (16:01 +0000)]
Use g_return_val_if_fail(), not g_return_if_fail(). (#318412, Kazuki

2005-10-07   Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
        g_return_val_if_fail(), not g_return_if_fail().  (#318412,
        Kazuki Iwamoto)

20 years agoAdd a has-selection property
Matthias Clasen [Fri, 7 Oct 2005 03:38:57 +0000 (03:38 +0000)]
Add a has-selection property

20 years agoRequire gmodule-no-export-2.0 instead of gmodule-2.0
Matthias Clasen [Wed, 5 Oct 2005 14:40:30 +0000 (14:40 +0000)]
Require gmodule-no-export-2.0 instead of gmodule-2.0

2005-10-05  Matthias Clasen  <mclasen@redhat.com>

* gdk-pixbuf-xlib-2.0.pc.in (Requires): Require
gmodule-no-export-2.0 instead of gmodule-2.0

20 years agoStart collecting release notes for 2.10.
Matthias Clasen [Wed, 5 Oct 2005 14:25:14 +0000 (14:25 +0000)]
Start collecting release notes for 2.10.

2005-10-05  Matthias Clasen  <mclasen@redhat.com>

* README.in: Start collecting release notes for 2.10.

20 years agoReadd the memory leak fix, since the assertion failures were traced to an
Matthias Clasen [Wed, 5 Oct 2005 14:11:23 +0000 (14:11 +0000)]
Readd the memory leak fix, since the assertion failures were traced to an

2005-10-05  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
leak fix, since the assertion failures were traced to
an xchat bug.  (#314696)

20 years agoDocumentation improvements. (gtk_style_detach): Assert that the
Matthias Clasen [Wed, 5 Oct 2005 13:23:21 +0000 (13:23 +0000)]
Documentation improvements. (gtk_style_detach): Assert that the

2005-10-05  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkstyle.c (gtk_style_detach):
(gtk_style_attach):  Documentation improvements.
(gtk_style_detach): Assert that the attach_count is > 0.

20 years agoDocument the "quick-bookmark" binding signal.
Federico Mena Quintero [Wed, 5 Oct 2005 05:12:06 +0000 (05:12 +0000)]
Document the "quick-bookmark" binding signal.

2005-10-05  Federico Mena Quintero  <federico@ximian.com>

* gtk/tmpl/gtkfilechooser.sgml: Document the "quick-bookmark"
binding signal.

20 years agoTake a shortcut position, not a ShortcutsIndex, to make the function more
Federico Mena Quintero [Wed, 5 Oct 2005 05:05:42 +0000 (05:05 +0000)]
Take a shortcut position, not a ShortcutsIndex, to make the function more

2005-10-04  Federico Mena Quintero  <federico@ximian.com>

* gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
shortcut position, not a ShortcutsIndex, to make the function more
generic.
(home_folder_handler): Pass the resolved index to
switch_to_shortcut(), rather than just SHORTCUTS_HOME.
(desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
(gtk_file_chooser_default_class_init): Add a "quick-bookmark"
binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0.  These
make the respective key switch to the first, second, ..., tenth
bookmark.
(quick_bookmark_handler): Implement.

20 years agoDocument the "desktop-folder" binding signal.
Federico Mena Quintero [Tue, 4 Oct 2005 20:20:47 +0000 (20:20 +0000)]
Document the "desktop-folder" binding signal.

2005-10-04  Federico Mena Quintero  <federico@ximian.com>

* gtk/tmpl/gtkfilechooser.sgml: Document the "desktop-folder"
binding signal.

20 years agoDon't special-case Home and Desktop; just use their real names on the file
Federico Mena Quintero [Tue, 4 Oct 2005 20:08:32 +0000 (20:08 +0000)]
Don't special-case Home and Desktop; just use their real names on the file

2005-10-04  Federico Mena Quintero  <federico@ximian.com>

* gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
Desktop; just use their real names on the file system for the
user-visible names.

* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_class_init): Add a "desktop-folder"
binding signal, and bind it to M-d by default.
(desktop_folder_handler): Implement the default handler.
(home_folder_handler): Use a helper function.
(switch_to_shortcut): New helper function.
(shortcuts_append_home): Don't special-case the name of "Home";
just use the folder name.

20 years agoMake it compile without HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias
Tor Lillqvist [Tue, 4 Oct 2005 13:42:27 +0000 (13:42 +0000)]
Make it compile without HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias

2005-10-04  Tor Lillqvist  <tml@novell.com>

* gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)

20 years agoRevert the change from yesterday, since it leads to assertion failures.
Matthias Clasen [Tue, 4 Oct 2005 04:20:02 +0000 (04:20 +0000)]
Revert the change from yesterday, since it leads to assertion failures.

2005-10-04  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
from yesterday, since it leads to assertion failures.  (#317879,
Sebastian Bacher)

20 years agoApply a patch to remove context from translations. (#317867, Duarte
Matthias Clasen [Tue, 4 Oct 2005 03:36:57 +0000 (03:36 +0000)]
Apply a patch to remove context from translations. (#317867, Duarte

2005-10-03  Matthias Clasen <mclasen@redhat.com>

* pt.po: Apply a patch to remove context from
translations.  (#317867, Duarte Henriques)

20 years agoCall calendar_compute_days() after setting priv->week_start.
Matthias Clasen [Tue, 4 Oct 2005 03:28:36 +0000 (03:28 +0000)]
Call calendar_compute_days() after setting priv->week_start.

2005-10-03  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkcalendar.c (gtk_calendar_init): Call
calendar_compute_days() after setting priv->week_start.

20 years agoUnref the style when removing it from the hash table. (#314696, Benjamin
Matthias Clasen [Mon, 3 Oct 2005 16:23:56 +0000 (16:23 +0000)]
Unref the style when removing it from the hash table. (#314696, Benjamin

2005-10-03  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
removing it from the hash table.  (#314696, Benjamin Berg)

20 years agoUse a 1k buffer for sniffing image formats, instead of 128 or 256 bytes.
Matthias Clasen [Mon, 3 Oct 2005 15:07:35 +0000 (15:07 +0000)]
Use a 1k buffer for sniffing image formats, instead of 128 or 256 bytes.

2005-10-03  Matthias Clasen  <mclasen@redhat.com>

* gdk-pixbuf-animation.c (gdk_pixbuf_animation_new_from_file):
* gdk-pixbuf-io.c (gdk_pixbuf_new_from_file):
* gdk-pixbuf-loader.c: Use a 1k buffer for sniffing image formats,
instead of 128 or 256 bytes.  (#317225, Sebastien Bacher,
Dom Lachowicz)

20 years agoIn case BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
Tor Lillqvist [Fri, 30 Sep 2005 23:56:42 +0000 (23:56 +0000)]
In case BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause

2005-10-01  Tor Lillqvist  <tml@novell.com>

* gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
is that the the desktop isn't visible because the session has been
switched, the screen is locked, or a terminal server session
disconnected, so no error message necessary. (#137796)

It is of course remotely possible that BitBlt() failing with
ERROR_INVALID_HANDLE might also be caused by some other
problem. We could strive for perfection and track whether the
desktop is visible by using WTSRegisterSessionNotification() and
handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
this issue, though. If we would track desktop visibility, we
should then avoid even trying to update the display at all while
the desktop isn't visible.

20 years agoUpdated Canadian English translation.
Adam Weinberger [Fri, 30 Sep 2005 20:44:35 +0000 (20:44 +0000)]
Updated Canadian English translation.

2005-09-30  Adam Weinberger  <adamw@gnome.org>

* en_CA.po: Updated Canadian English translation.

20 years agoAnother attempt to correct the calculations for the first week day. We may
Matthias Clasen [Fri, 30 Sep 2005 17:53:19 +0000 (17:53 +0000)]
Another attempt to correct the calculations for the first week day. We may

2005-09-30  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
to correct the calculations for the first week day. We may
just have to remove this code if too many locales turn out
to have broken data.

20 years agoDon't leak pixbuf in some cases. (#317611, Tommi Komulainen)
Matthias Clasen [Fri, 30 Sep 2005 15:40:55 +0000 (15:40 +0000)]
Don't leak pixbuf in some cases. (#317611, Tommi Komulainen)

2005-09-30  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
some cases.  (#317611, Tommi Komulainen)

20 years agoPrevent overflow when storing size hints in an unsigned short variable.
Matthias Clasen [Fri, 30 Sep 2005 14:57:02 +0000 (14:57 +0000)]
Prevent overflow when storing size hints in an unsigned short variable.

2005-09-30  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
        Prevent overflow when storing size hints in an unsigned
        short variable. Tracked down by Ray Strode and Søren Sandmann.

20 years agoCheck arguments. (#317491, Paolo Borelli)
Matthias Clasen [Thu, 29 Sep 2005 13:42:21 +0000 (13:42 +0000)]
Check arguments. (#317491, Paolo Borelli)

2005-09-29  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkbutton.c (gtk_button_set_image): Check arguments.  (#317491,
Paolo Borelli)

20 years agoStop drags when being grab shadowed. (#317332)
Matthias Clasen [Thu, 29 Sep 2005 13:35:01 +0000 (13:35 +0000)]
Stop drags when being grab shadowed. (#317332)

2005-09-29  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
grab shadowed.  (#317332)

20 years agoDLLs are always in bin nowadays, no need to test.
Tor Lillqvist [Thu, 29 Sep 2005 07:44:52 +0000 (07:44 +0000)]
DLLs are always in bin nowadays, no need to test.

2005-09-29  Tor Lillqvist  <tml@novell.com>

* gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.

20 years agoOops, return if the unmap test fails. (test_reload_sequence): Use
Federico Mena Quintero [Thu, 29 Sep 2005 01:56:10 +0000 (01:56 +0000)]
Oops, return if the unmap test fails. (test_reload_sequence): Use

2005-09-28  Federico Mena Quintero  <federico@ximian.com>

* tests/autotestfilechooser.c (test_reload_sequence): Oops, return
if the unmap test fails.
(test_reload_sequence): Use gtk_widget_show_now() instead of
gtk_widget_show() for the dialog.
Thanks to Tim Janik for noticing these.

20 years agoAdd a comment - Federico
Federico Mena Quintero [Thu, 29 Sep 2005 00:26:41 +0000 (00:26 +0000)]
Add a comment - Federico

20 years agoNew file with a set of tests for GtkCellRendererText. The idea is to run a
Federico Mena Quintero [Thu, 29 Sep 2005 00:19:32 +0000 (00:19 +0000)]
New file with a set of tests for GtkCellRendererText. The idea is to run a

2005-09-28  Federico Mena Quintero  <federico@ximian.com>

* tests/testcellrenderertext.c: New file with a set of tests for
GtkCellRendererText.  The idea is to run a text renderer through
most of its interesting property values to see that it works
correctly.

* tests/Makefile.am: Added testcellrenderertext.

* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
entry/exit of this function for profiling.
(gtk_file_chooser_default_style_set): Mark the start/end of the
calls to the parent class and the the signal emission for profiling.

20 years agoNew file with a set of tests for GtkCellRendererText. The idea is to run a
Federico Mena Quintero [Thu, 29 Sep 2005 00:19:15 +0000 (00:19 +0000)]
New file with a set of tests for GtkCellRendererText. The idea is to run a

2005-09-28  Federico Mena Quintero  <federico@ximian.com>

* tests/testcellrenderertext.c: New file with a set of tests for
GtkCellRendererText.  The idea is to run a text renderer through
most of its interesting property values to see that it works
correctly.

* tests/Makefile.am: Added testcellrenderertext.

* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
entry/exit of this function for profiling.
(gtk_file_chooser_default_style_set): Mark the start/end of the
calls to the parent class and the the signal emission for profiling.

20 years agoThe locale directory is passed to bindtextdomain() which isn't
Tor Lillqvist [Wed, 28 Sep 2005 23:46:10 +0000 (23:46 +0000)]
The locale directory is passed to bindtextdomain() which isn't

2005-09-29  Tor Lillqvist  <tml@novell.com>

* gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
passed to bindtextdomain() which isn't UTF-8-aware, so convert to
system codepage using g_win32_locale_filename_from_utf8().
(#317457, Kazuki Iwamoto)

20 years agoFree mult_atoms here. (#317039, Paolo Borelli)
Matthias Clasen [Wed, 28 Sep 2005 20:42:30 +0000 (20:42 +0000)]
Free mult_atoms here. (#317039, Paolo Borelli)

2005-09-28  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
here. (#317039, Paolo Borelli)

20 years agoChange header too
Matthias Clasen [Wed, 28 Sep 2005 20:28:54 +0000 (20:28 +0000)]
Change header too

20 years agoReturn the attributes to make this function work as boxed copy function.
Matthias Clasen [Wed, 28 Sep 2005 20:26:50 +0000 (20:26 +0000)]
Return the attributes to make this function work as boxed copy function.

2005-09-28  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
to make this function work as boxed copy function.  (#317455,
Gustavo Carneiro)

20 years agoDon't unref NULL. (#316828, Tor Lillqvist)
Matthias Clasen [Wed, 28 Sep 2005 20:06:08 +0000 (20:06 +0000)]
Don't unref NULL. (#316828, Tor Lillqvist)

2005-09-28  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkclipboard.c (request_image_received_func): Don't unref
NULL.  (#316828, Tor Lillqvist)

20 years agoInclude <config.h>. (#317444, Kazuki Iwamoto)
Tor Lillqvist [Wed, 28 Sep 2005 16:03:11 +0000 (16:03 +0000)]
Include <config.h>. (#317444, Kazuki Iwamoto)

2005-09-28  Tor Lillqvist  <tml@novell.com>

* modules/input/imime.c: Include <config.h>. (#317444, Kazuki
Iwamoto)

20 years agoDon't reload the current folder unnecessarily on ::map().
Federico Mena Quintero [Wed, 28 Sep 2005 01:07:08 +0000 (01:07 +0000)]
Don't reload the current folder unnecessarily on ::map().

2005-09-27  Federico Mena Quintero  <federico@ximian.com>

Don't reload the current folder unnecessarily on ::map().

* gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
the reloading state.
(struct _GtkFileChooserDefault): Added a "reload_state" field.

* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
Initialize impl->reload_state.
(gtk_file_chooser_default_map): Check the impl->reload_state; load
a default folder if no folder has been set, or reload the current
one only if we had been unmapped first.
(gtk_file_chooser_default_update_current_folder): Set the
reload_state to RELOAD_HAS_FOLDER.
(gtk_file_chooser_default_unmap): Implement, and set the
reload_state to RELOAD_WAS_UNMAPPED.
(shortcuts_model_create): Don't call shortcuts_add_bookmarks()
here; they'll get (re)loaded on ::map() anyway.

* gtk/gtkfilechooserwidget.c
(gtk_file_chooser_widget_constructor): Don't set a default folder here.

* tests/autotestfilechooser.c (test_action_widgets): Don't take in
a dialog; build it ourselves.
(test_reload): New test to ensure that we don't load the default
folder more than once, and that we reload it when
unmapping/remapping.
(get_impl_from_dialog): New utility function.
(test_widgets_for_current_action): Use get_impl_from_dialog().

20 years agoDon't reload the current folder unnecessarily on ::map().
Federico Mena Quintero [Tue, 27 Sep 2005 23:57:09 +0000 (23:57 +0000)]
Don't reload the current folder unnecessarily on ::map().

2005-09-27  Federico Mena Quintero  <federico@ximian.com>

Don't reload the current folder unnecessarily on ::map().

* gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
the reloading state.
(struct _GtkFileChooserDefault): Added a "reload_state" field.

* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
Initialize impl->reload_state.
(gtk_file_chooser_default_map): Check the impl->reload_state; load
a default folder if no folder has been set, or reload the current
one only if we had been unmapped first.
(gtk_file_chooser_default_update_current_folder): Set the
reload_state to RELOAD_HAS_FOLDER.
(gtk_file_chooser_default_unmap): Implement, and set the
reload_state to RELOAD_WAS_UNMAPPED.
(shortcuts_model_create): Don't call shortcuts_add_bookmarks()
here; they'll get (re)loaded on ::map() anyway.

* gtk/gtkfilechooserwidget.c
(gtk_file_chooser_widget_constructor): Don't set a default folder here.

* tests/autotestfilechooser.c (test_action_widgets): Don't take in
a dialog; build it ourselves.
(test_reload): New test to ensure that we don't load the default
folder more than once, and that we reload it when
unmapping/remapping.
(get_impl_from_dialog): New utility function.
(test_widgets_for_current_action): Use get_impl_from_dialog().

20 years agoMark the entry/exit of this function for profiling. (check_icon_theme):
Federico Mena Quintero [Tue, 27 Sep 2005 21:33:24 +0000 (21:33 +0000)]
Mark the entry/exit of this function for profiling. (check_icon_theme):

2005-09-27  Federico Mena Quintero  <federico@ximian.com>

* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_constructor): Mark the entry/exit of
this function for profiling.
(check_icon_theme): Likewise.
(change_icon_theme): Likewise.
(settings_notify_cb): Likewise.
(gtk_file_chooser_default_screen_changed): Likewise.
(update_chooser_entry): If the selection is empty, clear the file
name entry only if we are in CREATE_FOLDER mode.  In SAVE mode,
nothing will be selected when the user starts typeahead in the
treeview, and we don't want to clear the file name entry in that
case --- the user could be typing-ahead to look for a folder name.
Fixes bug #308332, patch by Jürg Billeter.

20 years agoPop below the entry if there's more free space below the entry than above.
Matthias Clasen [Tue, 27 Sep 2005 04:48:53 +0000 (04:48 +0000)]
Pop below the entry if there's more free space below the entry than above.

        * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
        Pop below the entry if there's more free space below the entry
        than above.  (#316948, Tommi Komulainen)

20 years agoDo not create the save mode-specific widgets in the open modes, so that we
Federico Mena Quintero [Tue, 27 Sep 2005 01:34:24 +0000 (01:34 +0000)]
Do not create the save mode-specific widgets in the open modes, so that we

2005-09-26  Federico Mena Quintero  <federico@ximian.com>

Do not create the save mode-specific widgets in the open modes, so
that we don't carry their baggage around.

* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_constructor): Don't create the
save_widgets here.
(save_widgets_create): Set the impl->save_widgets directly here,
instead of passing the widgets back to the caller.  Also, pack
them into the impl's box.
(update_appearance): Create or destroy the save widgets as
appropriate.  Set the action of the save_file_name_entry here.
(shortcuts_add_current_folder): Set the active item in the
save_folder_combo only if it exists.
(gtk_file_chooser_default_set_property): Don't set the action of
the save_file_name_entry here.
(gtk_file_chooser_default_update_current_folder): Set the base
folder of the save_file_name_entry only if the entry exists.
(shortcuts_drag_data_received_cb): Cast the selection_data->data
to (const char *) since that's what shortcuts_drop_uris() expects.
(file_list_drag_data_received_cb): Likewise, for
g_uri_list_extract_uris().

20 years agoSet the shaped flag here, too. (#316871)
Tor Lillqvist [Mon, 26 Sep 2005 20:59:31 +0000 (20:59 +0000)]
Set the shaped flag here, too. (#316871)

2005-09-26  Tor Lillqvist  <tml@novell.com>

* gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
the shaped flag here, too. (#316871)
(gdk_window_shape_combine_region): Currently unimplemented, so
don't do anything to the shaped flag here.

20 years agoFix #316871, reported by Dan Winship:
Matthias Clasen [Mon, 26 Sep 2005 20:27:44 +0000 (20:27 +0000)]
Fix #316871, reported by Dan Winship:

2005-09-26  Matthias Clasen  <mclasen@redhat.com>

Fix #316871, reported by Dan Winship:

* gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.

* gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
(gdk_window_shape_combine_region): Set it here.

* gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
remove the child area for shaped windows.

20 years agoFix a comment.
Matthias Clasen [Mon, 26 Sep 2005 20:10:40 +0000 (20:10 +0000)]
Fix a comment.

2005-09-26  Matthias Clasen  <mclasen@redhat.com>

* gdk/tmpl/gcs.sgml: Fix a comment.

20 years agoUpdated Swedish translation.
Christian Rose [Sat, 24 Sep 2005 22:39:00 +0000 (22:39 +0000)]
Updated Swedish translation.

2005-09-25  Christian Rose  <menthos@menthos.com>

* sv.po: Updated Swedish translation.

20 years agoUpdated Swedish translation.
Christian Rose [Sat, 24 Sep 2005 20:57:52 +0000 (20:57 +0000)]
Updated Swedish translation.

2005-09-24  Christian Rose  <menthos@menthos.com>

* sv.po: Updated Swedish translation.

20 years agoDon't leak expander pixbufs. (#316946, Tommi Komulainen)
Matthias Clasen [Fri, 23 Sep 2005 16:34:25 +0000 (16:34 +0000)]
Don't leak expander pixbufs. (#316946, Tommi Komulainen)

2005-09-23  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
Don't leak expander pixbufs.  (#316946, Tommi Komulainen)

20 years agogtk/gtk-docs.sgml gtk/gtk-sections.txt GtkCellRendererKeys ->
Michael Natterer [Thu, 22 Sep 2005 16:35:39 +0000 (16:35 +0000)]
gtk/gtk-docs.sgml gtk/gtk-sections.txt GtkCellRendererKeys ->

2005-09-22  Michael Natterer  <mitch@imendio.com>

* gtk/gtk-docs.sgml
* gtk/gtk-sections.txt
* gtk/gtk.types: GtkCellRendererKeys -> GtkCellRendererAccel

20 years agoRenamed GtkCellRendererKeys to GtkCellRendererAccel to be consistent with
Michael Natterer [Thu, 22 Sep 2005 16:33:50 +0000 (16:33 +0000)]
Renamed GtkCellRendererKeys to GtkCellRendererAccel to be consistent with

2005-09-22  Michael Natterer  <mitch@imendio.com>

Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
consistent with GTK+ terminology:

* gtk/gtkcellrendererkeys.[ch]
* tests/testkeys.c: removed...

* gtk/gtkcellrendereraccel.[ch]
* tests/testaccel.c: ...and added.

* gtk/Makefile.am
* gtk/gtk.h
* gtk/gtk.symbols
* tests/Makefile.am: changed accordingly.

20 years agoFix the documentation for the grab-broken-event signal, noticed by Damon
Matthias Clasen [Thu, 22 Sep 2005 14:46:23 +0000 (14:46 +0000)]
Fix the documentation for the grab-broken-event signal, noticed by Damon

2005-09-22  Matthias Clasen  <mclasen@redhat.com>

* gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
for the grab-broken-event signal, noticed by Damon Chaplin.